Closed jamesbraza closed 10 months ago
Hi @jamesbraza,
Editing 'hugo.toml' is evident if user wants flexibility and customization (which is the themes' motto).
A user should create a hugo.toml for his site in root.
I had never thought of this. So, in next push, I thinking to rename 'hugo.toml' to 'hugo.toml.example', so that a user have to create a 'hugo.toml'.
Let me know if this is acceptable, as about page could be different for all users, and it would be stupid of me if I should omit this crucial section.
Yeah I like what you suggest, it ensures:
hugo.toml
configFeel free to go down that route
An alternate solution could be a hugo.toml
with more generalized defaults. Perhaps the most generalized default is not specifying the fields within params.author
. For example you could rely on the user to read Explaining Configs, or have the repo's hugo.toml
be:
[params.author]
# about = "replace-me"
# name = "Replace Me"
What I'm thinking. I will remove hugo.toml which is used to generate the Demo site and add a new file called "hugo.toml.example".
There, I'll either comment out everything or put in default Replace Me values, and a link to Demosite's hugo.toml where user can see how that value is populated.
Added hugo.toml.example in place of hugo.toml with additional help on how to setup, so unless you have a hugo.toml in root, theme will not compile
Nice job! Looks like my site still works after this change 👌
An aside is it may good to go with staging
branch's readTimeSeparator
, I feel like that default is generalized
Yep, readTimeSeparator
is meant to be changed. You may copy from staging's toml, I'm not gonna stop you 😂😂
The fix in https://github.com/1bl4z3r/hermit-V2/commit/556699fcd783d9803ada8b7cd7c908a7eb7e362c has a side effect, which is my site starts using the hermit-V2's
about
option from the repo'shugo.toml
: https://github.com/1bl4z3r/hermit-V2/blob/556699fcd783d9803ada8b7cd7c908a7eb7e362c/hugo.toml#L41It leads to this error:
The issue arises because my About post in
content/
is not namedabout-hugo
, it's just namedabout
.Fix option 1 (falls onto users): when migrating to
[params.author]
, one has to override bothname
andabout
:Fix option 2 (falls onto hermit-v2): removing the
[params.author]
section from themain
branch'shugo.toml
What do you think? I am not sure which is the better route.