search

1bl4z3r / hermit-V2

Continuing Hermit's legacy to be minimal and fast theme
https://1bl4z3r.github.io/hermit-V2/
MIT License
101 stars 45 forks source link

[BUG] - No word count due to missing translation table #72

Closed bovender closed 3 months ago

bovender commented 3 months ago

Describe the bug When first using the hermit-V2 theme, no word count will be output for posts.

This is because the partial [posts-single-info.html](https://github.com/1bl4z3r/hermit-V2/blob/5ee9c821259bda1867ba3708992a8aa97bd095ed/layouts/partials/posts_single_info.html#L12) references a translation key wordCount, which by default does not exist:

<p>{{- partial "svg.html" (dict "context" . "name" "posts_single_wordcount") }}{{ i18n "wordCount" . -}} {{- partial "readTime.html" . -}}</p>

This confused me for a little while.

One could include a file i18n/en.toml in the theme directory structure with a "default" English translation, and explain in the README what to do if languages other than English are used.

What do you think?

1bl4z3r commented 3 months ago

Hi @bovender,

Thanks for the bug; and you're absolutely right. I'm an certified idiot. I overlooked dependence on translation key. For the time being please use the translation key from staging.

Rest assured, I'm going to update it within a few days

1bl4z3r commented 3 months ago

Hi @bovender,

I have changed few places to remove dependency on Translation key for English Language only. Also, I have updated Readme on how the translations work. Please let me know if you encounter any issues related to this, I would be happy to help.

bovender commented 3 months ago

Hi @1bl4z3r

Thanks so much, tried it, works great & I even discovered that the 404 page is supposed to have some text in it :rofl: