Support Non Animated - Githubissues

1bl4z3r / hermit-V2

Continuing Hermit's legacy to be minimal and fast theme

https://1bl4z3r.github.io/hermit-V2/

MIT License

101 stars 45 forks source link

Support Non Animated #84

Closed paisleyrob closed 1 month ago

paisleyrob commented 2 months ago

Would you accept Pull Requests that disable animation entirely?

Rather than override the following:

assets/scss/_animate.scss
layouts/404.html
layouts/_default/list.html
layouts/_default/single.html
layouts/partials/footer.html
layouts/partials/header.html
layouts/partials/social-share.html
layouts/partials/svg.html
layouts/posts/single.html

I'd add a configuration like useAnimation = true as a default so nothing changes, but I could set it to false and wouldn't include anything animation related.

1bl4z3r commented 1 month ago

Hi @paisleyrob,

Yes, I would absolutely accept PR. Although before submitting PR, I would urge you to throughly test if it breaks other components or not.

I.e. If animation is disabled, but a component has animation and vice-versa

1bl4z3r commented 1 month ago

Closing this issue as no further information was provided. Re-open if you have any more information to add and/or ask.

paisleyrob commented 1 month ago

Sorry I haven't gotten to this yet. Hopefully this week. Leave it closed for the moment as I'm not sure when I'll get to it.

1bl4z3r commented 1 month ago

Hi @paisleyrob,

Don't be so hard on yourself. This ain't life or death situation. Whenever you would be free and able, you can send a PR.

Wishing you the very best

paisleyrob commented 1 month ago

I'm going to push a Pull Request for this change shortly.