1bl4z3r / hermit-V2

Continuing Hermit's legacy to be minimal and fast theme
https://1bl4z3r.github.io/hermit-V2/
MIT License
103 stars 45 forks source link

feat: add option to toggle footer theme name display #85

Closed v0y4g3r closed 1 month ago

v0y4g3r commented 1 month ago

This PR:

Related issue:

1bl4z3r commented 1 month ago

Hi @v0y4g3r,

Thanks for the PR. Looks good, works well.

However, I would like to suggest a change. What you have done is set footerThemeName to false by default; it is preferable to default to true, but can be changed to false. Reason: Keeping same functionality as Original Theme.

If you want to work on this, you can, else I would have to make the change. Let me know your thoughts, or a suggestion

v0y4g3r commented 1 month ago

Hi @v0y4g3r,

Thanks for the PR. Looks good, works well.

However, I would like to suggest a change. What you have done is set footerThemeName to false by default; it is preferable to default to true, but can be changed to false. Reason: Keeping same functionality as Original Theme.

If you want to work on this, you can, else I would have to make the change. Let me know your thoughts, or a suggestion

I changed the option to footerHideThemeName in b7def36 so that the footer will remain the same if param.footerHideThemeName is not set in hugo.toml.

1bl4z3r commented 1 month ago

Hi @v0y4g3r,

Thanks a lot for the revision. It has been merged.