Closed v0y4g3r closed 1 month ago
Hi @v0y4g3r,
Thanks for the PR. Looks good, works well.
However, I would like to suggest a change.
What you have done is set footerThemeName
to false by default; it is preferable to default to true, but can be changed to false. Reason: Keeping same functionality as Original Theme.
If you want to work on this, you can, else I would have to make the change. Let me know your thoughts, or a suggestion
Hi @v0y4g3r,
Thanks for the PR. Looks good, works well.
However, I would like to suggest a change. What you have done is set
footerThemeName
to false by default; it is preferable to default to true, but can be changed to false. Reason: Keeping same functionality as Original Theme.If you want to work on this, you can, else I would have to make the change. Let me know your thoughts, or a suggestion
I changed the option to footerHideThemeName
in b7def36 so that the footer will remain the same if param.footerHideThemeName
is not set in hugo.toml
.
Hi @v0y4g3r,
Thanks a lot for the revision. It has been merged.
This PR:
footerThemeName
parameter inhugo.toml
to control the display of Hugo and Hermit-V2 theme tribute in the footer.footer.html
to conditionally display the tribute based on thefooterThemeName
parameter.Related issue:
28