search

1dot13 / source

Source code for the game executable of the Jagged Alliance 2 v1.13 project
102 stars 18 forks source link

Downgrade startup ini errors to warnings #229

Closed Xiaoxun92 closed 1 year ago

Xiaoxun92 commented 1 year ago

This PR resolves Downgrade startup ini errors to warnings

rftrdev commented 1 year ago

This looks fine, but can you post a screenshot of how this looks?

Edit: and how long are the warnings visible?

Xiaoxun92 commented 1 year ago

Sure! Here is the screenshot: image

The text took ~14s to disappear on my old Alienware laptop loading from an HDD. Might be faster on a better device. But either way, the for loop I deleted didn't help extend the visible time because the text only appeared after the loop finished running.

rftrdev commented 1 year ago

If you wanna do a follow up investigation as to why the same error is printed twice that'd be swell (but no pressure 🙂)

Xiaoxun92 commented 1 year ago

I noticed that as well and investigated it a bit :)

The same error message was generated in 2 places on startup:

  1. InitializeGame -> LoadGameExternalOptions
  2. InitializeGame -> LoadFeatureFlags -> UpdateFeatureFlags -> LoadGameExternalOptions

Any suggestions on how to improve it?