1dot13 / source

Source code for the game executable of the Jagged Alliance 2 v1.13 project
102 stars 18 forks source link

Remove use of Container.cpp #236

Closed Asdow closed 1 year ago

Asdow commented 1 year ago

Inspired by this comment at the top of the file

// 1998 KM Detached all references to this file from JA2 as it caused a lot of hard to debug crashes //The VOBJECT/VSURFACE lists are now self-maintained and no longer use the //this crap. DON'T USE THIS -- NO MATTER WHAT!!!

I'm removing all references to these old custom containers from the code. Contrary to the comment, they actually were still in use for example for VSURFACE.

Asdow commented 1 year ago

As of now, the only reference left is to HCONTAINER in FileMan.cpp -> GetFilesInDirectory() but that function is not used in the code. It's probably related to alternate code paths if VFS is not used. Might make sense to only remove it, and ultimately container.h & .cpp after we nuke all the #ifdefs related to VFS.