Closed kitty624 closed 1 month ago
r9343 introduced two new tags meant for items.xml which should prevent feature (food and disease) specific items to appear
(r9343 in gitHub: https://github.com/1dot13/source/commit/033ae4a191e5b4a888e58bdb55124cec5bb66dd7)
For the rework:
removed anything in it about the food feature
restricting food items to food feature was already implemented in code prior to r9343, therefore unnecessary
(see IsItemLegal, code by silversurfer)
removed the part about ShopKeeperInventory
since it's already been decided wether item is legal or not, it's unnecessary to do it again
(items already won't show in that inventory if not legal)
changed flags introduced by r9343 to boolean, allowing to simplyfy function in IsItemLegal
(now only dealing with disease feature)
removed the part that forced player to choose a feature to be able to see all possible merc gear sets
merc gear sets can now again contain such items without being not shown without the features
as a result we may see items for features we don't use, but we can choose between all five gear sets again
considering that we can easily dump or sell them, loosing whole gear sets seemed to harsh
tags introduced in r9343 never actually got implemeted into gamedir
therefore the now sole tag for disease will be added in an accompanying change to gamedir
tag strictly used for items that only have an effect with disease feature (mask/gloves, splint, disease medicine)
accompanying gamedir PR: https://github.com/1dot13/gamedir/pull/90
r9343 introduced two new tags meant for items.xml which should prevent feature (food and disease) specific items to appear
(r9343 in gitHub: https://github.com/1dot13/source/commit/033ae4a191e5b4a888e58bdb55124cec5bb66dd7)
For the rework:
removed anything in it about the food feature
restricting food items to food feature was already implemented in code prior to r9343, therefore unnecessary
(see IsItemLegal, code by silversurfer)
removed the part about ShopKeeperInventory
since it's already been decided wether item is legal or not, it's unnecessary to do it again
(items already won't show in that inventory if not legal)
changed flags introduced by r9343 to boolean, allowing to simplyfy function in IsItemLegal
(now only dealing with disease feature)
removed the part that forced player to choose a feature to be able to see all possible merc gear sets
merc gear sets can now again contain such items without being not shown without the features
as a result we may see items for features we don't use, but we can choose between all five gear sets again
considering that we can easily dump or sell them, loosing whole gear sets seemed to harsh
tags introduced in r9343 never actually got implemeted into gamedir
therefore the now sole tag for disease will be added in an accompanying change to gamedir
tag strictly used for items that only have an effect with disease feature (mask/gloves, splint, disease medicine)
accompanying gamedir PR: https://github.com/1dot13/gamedir/pull/90