Closed heyaarju closed 3 years ago
You provided nothing new in blockchain section just a freecodecamp link for a youtube channel that is already listed
You provided nothing new in blockchain section just a freecodecamp link for a youtube channel that is already listed
Oh, dammn. I am so sorry for that. The Blockchain README seemed too much cluttered to me and I was actually thinking of formatting those links to clickable course names (hyperlink).
I will remove the duplicate link and will update here. :D
Looks good
@Aarju02 Android Part looks good to me, just take a look at my comment. Also don't mark conversation resolved yourself, it should be marked resolved by the author as it helps in remembering the changes we wanted.
Understood! I'm sorry for marking it as resolved as I'm a bit new to GitHub and was experimenting with the "Resolve" toggle. I won't do that any further for sure! And also, does anything else looks off to you in my PR?
@Aarju02 Android Part looks good to me, just take a look at my comment. Also don't mark conversation resolved yourself, it should be marked resolved by the author as it helps in remembering the changes we wanted.
Understood! I'm sorry for marking it as resolved as I'm a bit new to GitHub and was experimenting with the "Resolve" toggle. I won't do that any further for sure! And also, does anything looks off to you in my PR?
No problem, we are here to help you out ! Just make sure that grammar is correct and you summarize the course overview in points.
@Aarju02 Android Part looks good to me, just take a look at my comment. Also don't mark conversation resolved yourself, it should be marked resolved by the author as it helps in remembering the changes we wanted.
Understood! I'm sorry for marking it as resolved as I'm a bit new to GitHub and was experimenting with the "Resolve" toggle. I won't do that any further for sure! And also, does anything looks off to you in my PR?
No problem, we are here to help you out ! Just make sure that grammar is correct and you summarize the course overview in points.
I have done my best to summarize the course contents as it's a bit long (~10 hrs) course and pointing out each and everything would probably eat up too much space and might seem cluttered. I just tried to have a balance in the course outline.
Though, it's on you, if you want me to add further more detailed points (I have actually covered everything but for say, rather than stating Java Essentials, I'd state each and every sub topics such as loops, class, etc) then I could do that too.
@Aarju02 I am suggesting to convert your current summary into points. For example -
Git is a Version Control Tool. It helps in keeping track of the changes in a project.
to
- Git is a Version Control Tool
- It helps in keeping track of the changes in a project.
Gotcha! Will do the changes in the next few minutes. Thanks for the feedback! :D
Quick Question:
I just wanted to ask, by when can I expect to get the review of other reviewers on this PR?
A bit excited to get going ahead, and as I'm a Hacktoberfest Participant, I'm also willing to get as many good PRs I can (though I am a newbie in this). Eagerly waiting for other reviewers to add their feedbacks here! ✧◝(⁰▿⁰)◜✧
@blank-27 @3scava1i3r @WolverienG6 can you please take a look?
@Aarju02 You'll have to resolve merge conflicts
@Aarju02 You'll have to resolve merge conflicts
Oh, sure. I'll fix that in the next few minutes :))
Please assign this to me.
@KingSlayr You can create a fresh pull request with resources you find to be helpful for beginners.
I contributed towards Issue: #29, #30, #31, #37 and #41 And my Discord Handle is: Aarju02#1748
I hope, my contributions prove to be helpful for this repo and feel free to ping me back with any feedback!