search

1hanzla100 / developer-portfolio

Software Developer Portfolio Template built with react.js and next.js bootstrap that helps you showcase your work and skills as a software developer.
https://developer-portfolio-1hanzla100.vercel.app/
Apache License 2.0
709 stars 454 forks source link

added dark theme support #28

Closed amirrezaDev1378 closed 1 year ago

amirrezaDev1378 commented 2 years ago

I have added simple functionality to switch themes.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
developer-portfolio ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 7:12AM (UTC)
1hanzla100 commented 2 years ago

@amirrezaDev1378 Found Few Bugs. need to fix them

amirrezaDev1378 commented 2 years ago

@1hanzla100 What bugs do you found? Can you give me a list please?

1hanzla100 commented 2 years ago

@1hanzla100 What bugs do you found? Can you give me a list please?

Iconify icons not loading Icon button for dark switch In dark mode imporve color contrast

amirrezaDev1378 commented 2 years ago

@1hanzla100 Ok, I will fix these until the next 24 hours

amirrezaDev1378 commented 2 years ago

Iconify is working correctly for me now, although I suggest switching to React icons package: https://react-icons.github.io/react-icons/

1hanzla100 commented 2 years ago

@amirrezaDev1378 we have to use Iconify because most of the development related icons are only available on iconify

amirrezaDev1378 commented 2 years ago

Do you need me to do something else?

1hanzla100 commented 2 years ago

@amirrezaDev1378 There are few this that need to be improved.

  1. In Light Mode of greeting text is black that should be white
  2. In Dark Mode Background of Greeting is Comparatively lighter
  3. In Dark The Experience & Contact section remain same that need to be fixed
  4. In Dark mode Cards bg Should be black as well with light grey shadow
  5. Dark Model bg color is too much dark make it #171c28