search

1hubert / genshin-dialogue-autoskip

A simple python script to automatically skip dialogue in Genshin Impact
MIT License
63 stars 23 forks source link

Update requirements.txt #29

Closed Carraraaa closed 10 months ago

Carraraaa commented 10 months ago

just adds pillow to the requirements list

1hubert commented 10 months ago

presentation

I've used the following commands to set up a clear Anaconda environment in order to test if the current requirements.txt need modifications:

git clone https://github.com/1hubert/genshin-dialogue-autoskip.git
cd genshin-dialogue-autoskip
conda create -n test
conda activate test
conda install python=3.12
pip install -r requirements.txt
autoskip_dialogue.py

As you see, the win32api is able to correctly detect my screen resolution. The rest of the script also works as intended. I appreciate your help as it's clearly intended to save other people's time which I respect a lot, but I don't want to add an extra module to requirements.txt without direct evidence that it's indeed needed for the script to work.

MercfifulZephyr commented 10 months ago

@1hubert hey im not sure if this helps but when i was changing to the most recent version of the script and had just installed the new requirements i got this error

pyautogui.PyAutoGUIException: PyAutoGUI was unable to import pyscreeze. (This is likely because you're running a version of Python that Pillow (which pyscreeze depends on) doesn't support currently.) Please install this module to enable the function you tried to call.

I'm running python 3.12.1 and all the most recent versions of the other packages. The script immediately worked after ran pip install pillow.