1hubert / genshin-dialogue-autoskip

A simple python script to automatically skip dialogue in Genshin Impact
MIT License
63 stars 23 forks source link

Receiving Item Issue #42

Open mokahless opened 4 months ago

mokahless commented 4 months ago

When an Item is received during dialogue, the script stops advancing. Happens consistently. Most recent test was receiving the "Sugar-Frosted Slime." Restarting the script does not get it to advance.

0withoutface0 commented 2 months ago

I'm pretty sure it's simply because its an unexpected scenario. There is no instruction in the code for what to do if an item is received (receiving the item probably breaks the main loop). if you can make or find a screenshot and or video of receiving an item i might be able to make a fix for it. (i dont have time to play the game these days and i dont even remember the last time i received an item from a dialogue so i wont be able to get the coordinates of pixels myself)

I know its an old issue but if someone wants this to get fixed they have to provide a video or screenshot of getting an item from a dialogue ingame.

mokahless commented 1 month ago

Here we go, got to another in the story. Now, there seem to be two ways of receiving an item. First, the one for maps or scrollable text, which has a large grey X in the top right. I'll leave that for another issue if I happen upon it again.

For this issue, however, pictured below, can be dismissed via a click of the mouse but not by F or Space.

item

I'd also like to note the way of dismissal and the triangle at the bottom are also in line with how white-on-black text dumps (often used for narrative time skips) are presented, which also require a mouse click to advance. Although I do not have a sample for now, it's as described and should operate like the above item receive image.

0withoutface0 commented 1 month ago

Oh wow alright i will look into it when i have time (studying comes first). tho i dont really know how i will solve this item receiving issue since there is no fix color anywhere on the screen with this, the only idea that comes to my mind is to check if there is any white on the screen after like 10 seconds (except the UID) and if no do a left mouse button click.

also, did you download the newer version i commited a month ago? im curious if its been working well. (since i dont play anymore i couldnt test it much)

mokahless commented 1 month ago

Here is the item receive version with the top-right "X."

image

Regarding the newer version, I've opened another issue regarding it: the new version committed a month ago seems entirely broken to me. I opened another issue about it after trying it on two different computers. I've been using a version from July for a while.

0withoutface0 commented 1 month ago

alright ty, i will probably make one function for both of the item receiving prompts, since i can click on the same coordinates