search

1hubert / genshin-dialogue-autoskip

A simple python script to automatically skip dialogue in Genshin Impact
MIT License
63 stars 23 forks source link

2560x1440 support #7

Closed bargouzine closed 1 year ago

bargouzine commented 1 year ago

hey,

I'm having a hard time running this is 1920 x 1080 windowed. My game wont let me play that fullscreen. Are you considering making this work for 2560 x 1440 ? I assume this would require changing every pixel coordinate in the script, but perhaps you know the values already.

Thanks a lot 👍

1hubert commented 1 year ago

Hey!

I don't know the exact values, but you could try to scale those values:

# Pixel coordinates for white part of the autoplay button.
KBM_AUTOPLAY_ICON_X: int = 111
KBM_AUTOPLAY_ICON_Y: int = 46

# Pixel coordinates for white part of the speech bubble in bottom dialogue option.
KBM_DIALOGUE_ICON_X: int = 1301
KBM_DIALOGUE_ICON_Y: int = 808

By dividing X values by 1920 and multiplying by 2560 (and then rounding to the nearest integer). And by dividing Y values by 1080 and multiplying by 1440 (and then rounding to the nearest integer).

I think that could work.

Sorry, don't have much time for hobbies currently. Wish you luck! ❤❤❤

1hubert commented 1 year ago

Hey @bargouzine

If you're still looking for 2560 x 1440 support, download the latest version of the main branch. Direct link: https://github.com/1hubert/genshin-dialogue-autoskip/archive/refs/heads/main.zip

The first time you'll run the run.bat file, it will auto-detect your screen resolution and ask for confirmation. After you confirm it's the correct resolution, it will be stored in .env file.

Let me know if that worked for you!

Have a nice day.