1ifeworld / river

Set information free.
https://river.ph
GNU Affero General Public License v3.0
25 stars 2 forks source link

Salief/index pagination #570

Closed salieflewis closed 3 months ago

salieflewis commented 3 months ago

Ready for review.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
river-site ✅ Ready (Inspect) Visit Preview Apr 5, 2024 6:42pm
river-site-metadata ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2024 6:42pm
railway-app[bot] commented 3 months ago

This PR is being deployed to Railway 🚅

river-delta-production: ◻️ REMOVED

salieflewis commented 3 months ago

approving made one smol comment/q below, and leaving a few notes for follow up:

  • think we want to figure out slightly more helpful pagination, that allows u to see what page index ur on (rather than just pure "prev/next")
  • think we want to do something (related to first point) about how crazy the urls get when using the end cursor as a url param

Honestly what makes the most sense, thinking about this even more, is just infinite scroll.