search

1ifeworld / river

Set information free.
https://river.ph
GNU Affero General Public License v3.0
25 stars 2 forks source link

adjust pagination controls location #574

Closed salieflewis closed 2 months ago

salieflewis commented 3 months ago

What do you think about the location of the pagination controls on desktop? I think it solves the issue where previously both the controls centered relative to the cards and centered relative to the page looks weird.

cc: @ioeylim

Also which routes should the footer extend to? Everything but the item view?

cc: @0xTranqui

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
river-site ✅ Ready (Inspect) Visit Preview Apr 8, 2024 5:25pm
river-site-metadata ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 5:25pm
railway-app[bot] commented 3 months ago

This PR is being deployed to Railway 🚅

railway-app[bot] commented 3 months ago

This PR is being deployed to Railway 🚅

river-delta-production: ◻️ REMOVED

ioeylim commented 3 months ago

What do you think about the location of the pagination desktop? I think it solves the issue where previously both centered relative to the cards and centered relative to the page looks weird.

cc: @ioeylim

I want to like it, but it's not really working for me.

ioeylim commented 3 months ago

Also yes – think footer should extend to everything but item view.