salief/channel page pagination

[salieflewis]

• update channel w/ id query
• update channel w/ id getter
• wip

--

Pushing this up so I don't lose the code, but going to try and first grab a more accurate number for the ChannelDetails component using a direct SQL query.

@ioeylim Do you have thoughts about how PaginationControls fits with the current placement of ChannelDetails? My first thought is that ChannelDetails gets moved somewhere to the top of the page such that the bottoms of both the index route and channel route are identical.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
river-site	✅ Ready (Inspect)	Visit Preview		Apr 10, 2024 8:15pm
river-site-metadata	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 10, 2024 8:15pm

[railway-app[bot]]

This PR is being deployed to Railway 🚅

river-delta-production: ◻️ REMOVED

[ioeylim]

• update channel w/ id query
• update channel w/ id getter
• wip

--

Pushing this up so I don't lose the code, but going to try and first grab a more accurate number for the ChannelDetails component using a direct SQL query.

@ioeylim Do you have thoughts about how PaginationControls fits with the current placement of ChannelDetails? My first thought is that ChannelDetails gets moved somewhere to the top of the page such that the bottoms of both the index route and channel route are identical.

Off-rip, I think channel pages should not be paginated and perhaps lazy loaded? I don't know how feasible this gets when a channel has like 400 items, but I do think it's nice/important to not break the flow

[salieflewis]

• update channel w/ id query
• update channel w/ id getter
• wip

-- Pushing this up so I don't lose the code, but going to try and first grab a more accurate number for the ChannelDetails component using a direct SQL query. @ioeylim Do you have thoughts about how PaginationControls fits with the current placement of ChannelDetails? My first thought is that ChannelDetails gets moved somewhere to the top of the page such that the bottoms of both the index route and channel route are identical.

Off-rip, I think channel pages should not be paginated and perhaps lazy loaded? I don't know how feasible this gets when a channel has like 400 items, but I do think it's nice/important to not break the flow

By lazy loaded I'm assuming you mean infinite scroll, correct? There is a large degree of changes that would need to be made in order to make that possible. Not saying it is impossible, but would require a bit of rearchitecting our component structure. I think it makes sense to continue with the existing pagination approach, are you opposed to this?

If not can I pose the original question to you again.

[ioeylim]

• update channel w/ id query
• update channel w/ id getter
• wip

-- Pushing this up so I don't lose the code, but going to try and first grab a more accurate number for the ChannelDetails component using a direct SQL query. @ioeylim Do you have thoughts about how PaginationControls fits with the current placement of ChannelDetails? My first thought is that ChannelDetails gets moved somewhere to the top of the page such that the bottoms of both the index route and channel route are identical.

Off-rip, I think channel pages should not be paginated and perhaps lazy loaded? I don't know how feasible this gets when a channel has like 400 items, but I do think it's nice/important to not break the flow

By lazy loaded I'm assuming you mean infinite scroll, correct? There is a large degree of changes that would need to be made in order to make that possible. Not saying it is impossible, but would require a bit of rearchitecting our component structure. I think it makes sense to continue with the existing pagination approach, are you opposed to this?

If not can I pose the original question to you again.

Thoughts on this comment @salieflewis?

[salieflewis]

New PR is #586

Keeping this up for the comments.