search

1ifeworld / river

Set information free.
https://river.ph
GNU Affero General Public License v3.0
25 stars 2 forks source link

tell biome to read from the version specified in the root directory #614

Closed salieflewis closed 2 months ago

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
river-site ✅ Ready (Inspect) Visit Preview May 2, 2024 8:42pm
river-site-metadata ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2024 8:42pm
salieflewis commented 2 months ago

Resolves #615

salieflewis commented 2 months ago

looks good to me and approving. only qs i have for u are

  • how do we know what version of biome we are happy with / when it calls for an update?
  • are there any changes to the workflow of running pnpm format + pnpm lint in the appropriate app folder before pushing up a pr?

Basically before, biome wasn't able to resolve what the current version installed was because it was looking in the wrong place. By default it pulls from the latest stable version on npm. Thats why in order to fix things we needed to bump biome. This PR fixes that, so whatever version we have installed now will be what it listens to. I think we only need to consider bumping again when a major update occurs and new/wanted functionality becomes available.

There are no changes, and you can run those commands from the root of the repo.