adjust grid logic - Githubissues

1ifeworld / river

Set information free.

https://river.ph

GNU Affero General Public License v3.0

25 stars 2 forks source link

adjust grid logic #625

Closed salieflewis closed 4 months ago

salieflewis commented 4 months ago

@ioeylim Does this look as you intended it to?

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
river-site	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 1, 2024 6:13pm
river-site-metadata	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 1, 2024 6:13pm

ioeylim commented 4 months ago

Looks great. Just noting that the fallback cards don't dynamically resize in some of the more awkward in between/huge sizes. But I think this is an edge case and we can merge.

salieflewis commented 4 months ago

Looks great. Just noting that the fallback cards don't dynamically resize in some of the more awkward in between/huge sizes. But I think this is an edge case and we can merge.

That is a good catch. I'll update the media icons first with this in mind, and then make this change after instead of making changes to a component that will disappear.