1inch / shieldy

@shieldy_bot Telegram bot repository
https://t.me/shieldy_bot
MIT License
839 stars 254 forks source link

Unban user after time runs out #24

Closed BiroStorm closed 4 years ago

BiroStorm commented 5 years ago

Hello,

I just discovered that if the bot kicks out a user, the user will be unban (or unlimited) and can rejoin the group without limitations. To simulate, it's very simple:

I recreated this bug multiple times and it can cause conflict with other bot (like antistormbot) that ban immediately Arab users or userbot.

Thanks.

backmeupplz commented 5 years ago

It's not a bug, it's a feature. Shieldy kicks users, it doesn't ban them.

BiroStorm commented 5 years ago

Exactly, Shieldy kicks users but to do that automatically unban the user if he is already banned. This is what I mean ^^''

backmeupplz commented 5 years ago

Oh, I see what you mean. Yeah, it's a known issue, I'm working on it

backmeupplz commented 5 years ago

I've added a task to check if Shieldy is overwriting the permissions again

backmeupplz commented 4 years ago

Alright, after investigation I've found that Shieldy might interfere with other bots by unbanning them (it kicks users, doesn't ban them). So I've introduced /banUsers command that will ban the users forever instead :)