WETH -> wstETH pricing is inverted with wrappers enabled

1inch / spot-price-aggregator

Liquidity-weighted dex price oracle for offchain price discovery

MIT License

273 stars 79 forks source link

WETH -> wstETH pricing is inverted with wrappers enabled #145

Closed blakearnold closed 3 months ago

blakearnold commented 4 months ago

When quoting mainnet WETH (0xc02aaa39b223fe8d0a0e5c4f27ead9083c756cc2) -> wstETH (0x7f39c581f595b53c5cb19bd0b3f8da6c935e2ca0) the price returned is inverted and instead returns the wstETH -> WETH price when wrappers are enabled.

wstETH -> WETH is correct

WETH -> wstETH should be inverted, but is not

This is not an issue without wrappers:

zZoMROT commented 4 months ago

Indeed, it seems there is a problem with the use of wrappers for dstToken. Thank you for identifying and highlighting this.

zZoMROT commented 3 months ago

The bug has been fixed in the new version of OffchainOracle. The new address of the main contract is:

0xf224a25453D76A41c4427DD1C05369BC9f498444 on all networks
0xdCa3e52Af86F8244fd0EDA8064Dc30E154d93033 on the zkSync network

Thank you for the improvement suggestion!