search

1iveowl / WebsocketClientLite.PCL

Websocket client lite
MIT License
39 stars 14 forks source link

Three Fixes #78

Closed rnatau closed 1 year ago

rnatau commented 2 years ago

A) (important) - ClientPing is not disposed on connection close, leading to pings to nowhere. Maybe I found the right place to trigger the disposal, maybe not ;-)

B) (important) I had issues with all my WebSocket use cases, as my replies to server pings were not accepted. See my working solution, which clearly should not be taken over as-is.

C) (optional) During debugging I got exceptions for concurrent write accesses. so I protected it with a semaphore. Not sure if relevant in practice, but might make sense to integrate.

1iveowl commented 1 year ago

Thanks for these. Will take a look at it asap.

Regarding C), can you remember how to reproduce? Maybe it’s more of a debugging issue than a RL issue, but worth looking in to.