search

1iveowl / WebsocketClientLite.PCL

Websocket client lite
MIT License
38 stars 14 forks source link

IsConnected always true. #9

Closed cmisztur closed 7 years ago

cmisztur commented 7 years ago

IsConnected is never set to false after CloseAsync().

1iveowl commented 7 years ago

Should be fixed now. Please confirm?

cmisztur commented 7 years ago

Probably need one more here somewhere when server requests a disconnect: https://github.com/1iveowl/WebsocketClientLite.PCL/blob/master/src/main/Service/WebsocketListener.cs#L55

1iveowl commented 7 years ago

Thanks.

Please see and test v.3.6.1-beta2 and feed your observations back to me.

You'll find the code in the develop branch.

cmisztur commented 7 years ago

Ok, before I continue, I want to check with you if these are the correct libraries: http://imgur.com/a/YGvdn

Also I had to bump your libraries to .NETStandard1.5. One complained that a dependency needed 1.3 and all were at 1.2 so I just bumped them to 1.5.

1iveowl commented 7 years ago

Yes and no. I would suggest that you test by using the NuGet.

The network stack is not fully complete in .NET Standard (will be when Microsoft release .NET Standard 2.0 some time next year I suppose). To work around this I'm using Bait and Switch to provide your library with either PCL library (for anything below .NET Standard 1.5) or else the .NET Standard 1.5 library.

cmisztur commented 7 years ago

Cool, neat trick! Ok, I went back to nuget. I'm leaving this open still since the code around cancellation token is different now.

1iveowl commented 7 years ago

Closing as the cancellation token part has a seperate issue