1j01 / 98

💿 Web-based Windows 98 desktop recreation █████▓█▓▓▒▓▒▒░▒░░░🗕︎🗗︎🗙︎
https://98.js.org
1.15k stars 183 forks source link

Add notepad #3

Closed kirkins closed 7 years ago

kirkins commented 7 years ago

Adding a notepad example. Saves text to local storage. Would like to add a save button instead. Maybe I can copy some of your code from the paint app.

1j01 commented 7 years ago

Sorry for not responding until now. I've honestly put it off because, while I'd like to merge this, I have several problems with it and I don't want to ask you to make a bunch of changes.

The main thing is that notepad doesn't need to be a rich text editor. Other than that, the icon pack is unrelated to adding notepad and shouldn't really be part of the same PR. I can only easily merge the whole thing at once. Plus for consistency, I'd want capitalization of commit messages and dashes in filenames as opposed to underscores.

I think the easiest thing would be for me to recreate this feature myself, especially since I'd want to dust off the project and refactor a bunch of things anyways.

1j01 commented 7 years ago

I added Notepad in https://github.com/1j01/98/commit/21a021a0704f1f1a860427edc8aedbc9df27eda6 (and further commits), still missing file management and some other features. I'll probably work on Paint, and then do file handling stuff next.

1j01 commented 6 years ago

I have still not done the file handling stuff...

kirkins commented 6 years ago

you use to be cool