Edit Colors window doesn't work on Microsoft Edge and Brave browser

1j01 / jspaint

🎨 Classic MS Paint, ＲＥＶＩＶＥＤ + ✨Extras

https://jspaint.app/about

MIT License

7.18k stars 560 forks source link

Edit Colors window doesn't work on Microsoft Edge and Brave browser #206

Closed LTrue130 closed 3 years ago

LTrue130 commented 3 years ago

I tried firefox, and it works just fine, but I don't use it because it's very choppy.

I noticed that the window tries to open, but it fails.

1j01 commented 3 years ago

Yeah so currently it uses the browser's built-in color picker, and I don't know if this is failing because of some stupid security measure these browsers implement or what, but I've actually started implementing the Windows 98 color picker. The thing is, I lost a ton of work on it when my hard drive crashed, so I've been demotivated from working on jspaint for a while. I think I'm gonna start working on it again soon, but no promises.

polygonnedpotato commented 3 years ago

this is also affected for all chromium browsers altogether, However, I think there is a developer flag for an upcoming colour picker.

EDIT: No, there isn't for at least chromium 85 EDIT 2: There is a new feature actually in chromium 85. it can be enabled at chrome://flags/#enable-experimental-web-platform-features .

1j01 commented 3 years ago

I've mostly reimplemented the Edit Colors dialog. Here's a comparison between a real screenshot and my recreation: Peek 2020-12-04 00-31 Just a few more things to do before I can push this.

1j01 commented 3 years ago

I implemented the Edit Colors dialog! Pushed to production. Now it's consistent across platforms, and retro, and can't have any problems from not being triggered via a user gesture, which means it should work to open it via speech recognition, or eye gaze mode... and this should be fixed!

LTrue130 commented 3 years ago

Awesome! Thnaks!!