Exit button does not close the Electron app

1j01 / jspaint

🎨 Classic MS Paint, ＲＥＶＩＶＥＤ + ✨Extras

https://jspaint.app/about

MIT License

7.17k stars 562 forks source link

Exit button does not close the Electron app #280

Closed Svahnen closed 2 months ago

Svahnen commented 2 years ago

I am aware the desktop edition is not released yet but I could not find this issue documented anywhere. I built and installed the Electron desktop version on Ubuntu 20.04.

The Exit button found under "File" menu redirects to https://98.js.org/ instead of closing the program.

1j01 commented 2 months ago

Fixed in https://github.com/1j01/jspaint/commit/82927b062c9955e95e020d1fd932a9753d01f21f, and then I just fixed it missing a save prompt for unsaved changes in https://github.com/1j01/jspaint/commit/e1bf0d73b59bb6a5a8a4404e2a2c4528d4b72566