search

1j01 / jspaint

🎨 Classic MS Paint, ＲＥＶＩＶＥＤ + ✨Extras
https://jspaint.app/about
MIT License
7.27k stars 571 forks source link

Manage Storage bug: Blank canvas is not saved in localStorage #96

Closed wuweiweiwu closed 6 years ago

wuweiweiwu commented 6 years ago

It is only saved when you start drawing.

Is this intentional? I was thinking that when you open a new canvas, it should automatically have that canvas in localStorage

1j01 commented 6 years ago

This is intentional, but I'm open to changing it. Presumably a blank PNG compresses well, so the actual storage usage wouldn't be an issue. But saving a new session immediately can add clutter to the UI when you're managing storage. Why do you think it should save an empty canvas?

wuweiweiwu commented 6 years ago

I was thinking that if the user opened manage storage and didn't see anything in "manage storage" They would think that you need to save / save as / or someway to save it in storage. It seems more intuitive to see that your current canvas is in storage.

1j01 commented 6 years ago

Okay, that's valid.

wuweiweiwu commented 6 years ago

Ill submit a PR in a bit :)