search

1kastner / conflowgen

A generator for synthetic container flows at maritime container terminals with a focus on yard operations
MIT License
11 stars 7 forks source link

Unit test coverage #117

Closed ram24prasath closed 2 years ago

ram24prasath commented 2 years ago

improved unit test coverage.

1kastner commented 2 years ago

@ram24prasath thank you for the PR. Some checks are still failing. Please fix these first. You can run the checks locally by executing run_ci_light.bat on the project root level.

lgtm-com[bot] commented 2 years ago

This pull request introduces 4 alerts when merging 890c34ab759835d0b99e5e62d3e581cf7424b63e into 9dd043dd7b2773509e83505985aef73cc5fb071f - view on LGTM.com

new alerts:

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
29.5% 29.5% Duplication

lgtm-com[bot] commented 2 years ago

This pull request introduces 4 alerts when merging 95bd7f308714009d41d4c443837b144d36162a25 into 9dd043dd7b2773509e83505985aef73cc5fb071f - view on LGTM.com

new alerts:

1kastner commented 2 years ago

@ram24prasath: Please drop the comment # pylint: disable=import-outside-toplevel for all imports which you moved to the toplevel import section.

codecov-commenter commented 2 years ago

Codecov Report

Merging #117 (7e8b4f1) into main (9dd043d) will increase coverage by 4.12%. The diff coverage is 98.27%.

@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   87.93%   92.06%   +4.12%     
==========================================
  Files         101      102       +1     
  Lines        3524     3553      +29     
==========================================
+ Hits         3099     3271     +172     
+ Misses        425      282     -143
Impacted Files Coverage Δ
...en/posthoc_analyses/modal_split_analysis_report.py 98.80% <94.44%> (+25.73%) :arrow_up:
...flow_adjustment_by_vehicle_type_analysis_report.py 100.00% <100.00%> (+37.25%) :arrow_up:
...ustment_by_vehicle_type_analysis_summary_report.py 100.00% <100.00%> (+13.79%) :arrow_up:
.../container_flow_by_vehicle_type_analysis_report.py 100.00% <100.00%> (+40.90%) :arrow_up:
...d_and_outbound_vehicle_capacity_analysis_report.py 100.00% <100.00%> (+23.80%) :arrow_up:
...nd_vehicle_capacity_utilization_analysis_report.py 87.50% <100.00%> (+37.00%) :arrow_up:
...c_analyses/quay_side_throughput_analysis_report.py 100.00% <100.00%> (+28.57%) :arrow_up:
..._analyses/truck_gate_throughput_analysis_report.py 100.00% <100.00%> (+31.57%) :arrow_up:
.../posthoc_analyses/yard_capacity_analysis_report.py 90.27% <100.00%> (+16.36%) :arrow_up:
conflowgen/reporting/no_data_plot.py 100.00% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9dd043d...7e8b4f1. Read the comment docs.

1kastner commented 2 years ago

CodeFactor issue seems related to https://github.com/PyCQA/pylint/issues/3507 and is a false positive, thus ignored until fixed at CodeFactor.