1kc / razer-macos

Color effects manager for Razer devices for macOS. Supports High Sierra (10.13) to Monterey (12.0). Made by the community, based on openrazer.
GNU General Public License v2.0
2.31k stars 252 forks source link

[Improvement proposition] Installation and development process/procedures. #186

Open aamkye opened 3 years ago

aamkye commented 3 years ago

Hey @1kc, first of all great work <3 Have You thought about dropping copy&paste method from openrazer repo and treat them as external dependency? Can You describe what are the differences between drivers in this repo and the in openrazer repo? I'd like to also create brew formula for this and openrazer project (If we would be able to treat them as ext-dep).

But I need Your help to better understand differences.

sourav-dey commented 3 years ago

The problem is openrazer is linux specific. This is mac specific,so other than some business logic, most of it needs to be modified to support mac specific libraries.

1kc commented 3 years ago

Hi Iodufqa,

If you look under the wiki page on GitHub, there should be a page highlighting what needs to be done for device drivers to be ported over.

Despite sharing most of the code with openrazer, a lot of the function signatures and variables needs to be manually changed. We haven’t found a way to automatically port things across, like a script for example. I’m open to new approaches though so let me know you thoughts once you’ve taken a look at it.

On 10 Jan 2021, at 12:06 pm, lodufqa notifications@github.com wrote:



Hey @1kchttps://github.com/1kc, first of all great work <3 Have You thought about dropping copy&paste method from openrazer repo and treat them as external dependency? Can You describe what are the differences between drivers in this repo and the in openrazer repo? I'd like to also create brew formula for this and openrazer project (If we would be able to treat them as ext-dep).

But I need Your help to better understand differences.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/1kc/razer-macos/issues/186, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE7AB4EAT7753T2TOSRAJLLSZEDRLANCNFSM4V4BH4UA.

aamkye commented 3 years ago

Ok, I've found info about common, chroma common and keyboard drivers, what about mices? They don't need to be ported, do they?

I'd did the research about which exactly function signatures are being translated from Linux to MacOS and what are the differences.

I was thinking about implementing those differences as a separate build targets, in openrazer repo.

Will get back to You soon.