1lann / Mimic

A fully featured emulator for the Minecraft mod ComputerCraft that runs straight in your browser.
gravlann.github.io
MIT License
45 stars 20 forks source link

Crash #65

Closed terreng closed 9 years ago

1lann commented 9 years ago

I can't seem to reproduce it, could you provide some logs from the JavaScript console?

dmarcuse commented 9 years ago

This sounds like a problem with your browser being slow. What browser are you using and what are your specs?

dmarcuse commented 9 years ago

Unlimited storage? Wat?

What is your processor and memory, those are the two key factors here. For example, I use an AMD FX-6300 processor overclocked to 4.5 GHz, and have 16 GB of DDR3-1600 memory.

1lann commented 9 years ago

Perhaps try using sunspider to test your performance? https://www.webkit.org/perf/sunspider-1.0.2/sunspider-1.0.2/driver.html

Also to show the JavaScript console, right click on blank area on page -> Inspect element -> Console tab

Could you also post EXACT steps to reproduce the problem?

1lann commented 9 years ago

Sorry I forgot to reply, I'll take a look at it sometime, however with my experiences so far there doesn't see to be any problems when I use safari. On Tue, 31 Mar 2015 at 9:26 am Joah notifications@github.com wrote:

You might want to add something like: "May not work correctly in Safari"

Again, is this closed or are you planning to make a fix just for Safari?

— Reply to this email directly or view it on GitHub https://github.com/1lann/Mimic/issues/65#issuecomment-87893692.

1lann commented 9 years ago

I can't seem to reproduce it, however yielding is done per Lua function call basis, and thread unresponsiveness errors occur when you haven't yielded for 5 seconds. I tried doing some profiling, Safari yielded no results as it captured nothing for some reason, and Chrome stated that the longest call to JavaScript (single yield) lasted for 300 ms, and that was when I was opening Ink. That isn't enough to cause a too long without yielding or a thread unresponsive error. You'll need that to be slower by a factor of 10 before it has the chance of having too long without yielding.

I really cannot see any performance issues and I cannot reproduce the problem, it works perfectly fine for me on Safari 8.0.2 on Yosemite 10.10.1. Are you not running any ComputerCraft "OSes" or additional programs that are running in the background of ComputerCraft that could cause slow downs? How do other emulators run on your computer?

1lann commented 9 years ago

Could you try not running jupiterOS?

1lann commented 9 years ago

Try doing a for i = 1, 10000000 do print(i) end and tell me what number you end at before it errors with too long without yielding.

1lann commented 9 years ago

Although your computer seems abnormally slow (that's around the same number I get on my phone, on my computer I can get up to 1000), I really cannot reproduce this problem. Even my phone with Chrome can pastebin get ink and run ink with no issues. It might really just be that your computer is too slow which is really strange because Macs shouldn't be that slow to the extent of my phone. Unless someone can provide a lead to what would be causing the problem, I cannot resolve this. I'd say just avoid using Safari for Mimic.

1lann commented 9 years ago

Waititiawiwait you're using Safari on a PC????!?! Apple has dropped support for Safari on Windows 3 years ago... Are you really using that old of a version of Safari on a Windows computer?

dmarcuse commented 9 years ago

While we're on this topic, every time I try to use pastebin on Chrome, it always fails with a 503 in the javascript console. Same result in Firefox and (blah) Internet Explorer.

1lann commented 9 years ago

@apemanzilla I'm using a CORS proxy hosted by Yahoo, so there's really nothing I can do about the 503s from Yahoo's servers. I could switch it to one that I own in the future, or perhaps a better CORS proxy.

@JoahDave wait so are you using a Mac or a Windows computer? And were you really using Safari/did this problem actually exist?

dmarcuse commented 9 years ago

Maybe allow the user to specify a custom proxy IP/URL?

I should probably split this into it's own issue.