search

1nikolas / play-integrity-checker-app

Get info about your Device Integrity through the Play Intergrity API
MIT License
333 stars 47 forks source link

patch: Translate: Add zh-rTW Translate #13

Closed bluehomewu closed 1 year ago

bluehomewu commented 1 year ago

Hello, I'm a Taiwanese, who works on Android and Translation projects.

bluehomewu commented 1 year ago

CC: @1nikolas Please review it. Thanks you so much.

1nikolas commented 1 year ago

Thanks for this! There is a small problem though. translatable="false" strings can't be translated and will result to an error. You'll have to either remove translatable="false" from both the translated strings.xml and the original strings.xml (in the case of app_name and app_name_short) or don't include them in your translated xml (everything else with translatable="false"). Also while at it you can also translate the docs link (I think this is the one https://developer.android.com/google/play/integrity/verdict?hl=zh-tw#device-integrity-field)

bluehomewu commented 1 year ago

Hi, @1nikolas Sorry about that, I forgot to check that flag. Here's commit for fixup.

1nikolas commented 1 year ago

Looks good thanks

bluehomewu commented 1 year ago

Looks good thanks

Nicee! Hope can get new update for this application soon.