1oly / AeroAcoustics.jl

A Julia package for Aeroacoustics
Other
27 stars 3 forks source link

Update a few dependencies #5

Closed dkarrasch closed 1 year ago

dkarrasch commented 1 year ago

A came across this package in a pkgeval run on Julia Base. Some of the compat requirements force this package to use very old package versions, so this PR tries to lift them to the current versions. You may want to consider using CompatHelper.jl.

1oly commented 1 year ago

Thanks @dkarrasch ! This is long overdue, thanks for the PR.

dkarrasch commented 1 year ago

You need to approve the CI workflow (since I'm an outsider ;-) ) so that the changes get tested.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.20 :warning:

Comparison is base (e834c50) 74.01% compared to head (4bf69d6) 73.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #5 +/- ## ========================================== - Coverage 74.01% 73.82% -0.20% ========================================== Files 11 11 Lines 408 447 +39 ========================================== + Hits 302 330 +28 - Misses 106 117 +11 ``` [see 9 files with indirect coverage changes](https://codecov.io/gh/1oly/AeroAcoustics.jl/pull/5/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Lylloff) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Lylloff). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Oliver+Lylloff)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

dkarrasch commented 1 year ago

Gentle bump.

1oly commented 1 year ago

Finally. Thanks @dkarrasch !