search

1oom-fork / 1oom

1oom is a Master of Orion (1993) game engine recreation that requires the original files to run.
GNU General Public License v2.0
52 stars 7 forks source link

Change custom game 'Players' option text to 'Opponents' #4

Closed oblivioncth closed 1 year ago

oblivioncth commented 1 year ago

The value this option sets is actually the number of opponents, as in the original game creation menu, and not the total number of players.

"Players" is misleading as it leads one to assume it includes themselves, and as such if they wanted to start a game with 3 opponents they'd likely set Players to 4; however, upon reaching the next screen they'd come to find that there were actually 4 opponents, with 5 players total.

Of course this also seems silly with just one opponent, as "Players 1" doesn't make any sense at first glance since you can't start a game with just one race.

The term "Player" could be kept and the logic behind the option shifted so that it instead is restricted between 2-6 in the UI, while actually passing it's value - 1 to the rest of the game setup, but this would obviously require more work.

1oom-fork commented 1 year ago

"Players 2-6" looks better because of multiplayer Merged. Thanks for the feedback.

oblivioncth commented 1 year ago

I really confused about how GitHub tracked this since it doesn't show your commit here and marked this as closed and unmerged, but still has me as the author of the modified commit.

I've barely glanced parts of the codebase, but I'm also not quite sure how the change that went through actually alters the way the number is handled (it just seems like it removed the ability to load the a custom value via the command-line or config). Didn't know if it was just a portion of something you're going to follow up with.

I'm just curious and am trying to follow along is all.

Regardless, I agree Players 2-6 is best.

1oom-fork commented 1 year ago

In this case, the author is the one who pointed out the error and solutions. https://github.com/1oom-fork/1oom/commit/cd0f1be223204449b506aac788cdcb88a09a247e