1rosehip / jplist

jPList jQuery Data Grid Controls is a flexible jQuery plugin for sorting, pagination and filtering of any HTML structure (DIVs, UL/LI, tables, etc).
http://jplist.com
Other
436 stars 177 forks source link

CSS might be improveable #252

Open onli opened 7 years ago

onli commented 7 years ago

Hi, please regard this as a mix of a feature request and feedback. I did not find another issue that mentions it.

Like mentioned in my other feature request, jplist impressed me. But I had some issues with the CSS, and wanted to share that pain point. Those were mine:

  1. The css assumes a specific naming for the panel class, despite the panel class being configurable
  2. Some of the controls assume a css file, but don't present it on the download list. I fetched those from their example page.
  3. The .lato class seems strange to me, that just won't work in most proejcts
  4. The float: left approach did not work for me, as it fails to resize the container when the page gets too small. I replace that with inline-block, but it could also work well with flexbox.
  5. Since I had to modify the code, it would have been easier for me if the download page would not link the minimized files but the original sources, at least additionally.

I can share the modifications I did, if you are interested. Not generic enough for a PR, but maybe enough to give an idea what improvements might be possible.

In any case, keep up the good work ❤️