search

1runeberg / OpenXRProvider_v2

Provides a simpler C++ interface to the OpenXR api. Also includes an optional render module introduced in Demo 5 (Hello PBR). Currently an active work in progress with testing done in both Android (Meta Quest), Win64 and Linux.
MIT License
34 stars 3 forks source link

Adds XR_HTCX_vive_tracker_interaction extension, demo demonstrating use #2

Closed CharlotteGore closed 1 year ago

CharlotteGore commented 1 year ago

Adds support for Headless OpenXR sessions and HTC Vive Trackers, which I believe demonstrates using the library in Virtual Production contexts where tracked input is required but rendering is not, or on systems where an HMD is not present.

The Vive tracker extension does add support for the function the extension adds, but doesn't demonstrate using it.

CharlotteGore commented 1 year ago

(I changed my mind on this and decided that cleaning up the PR a little bit and just leaving it for @1runeberg to decide is fine)

1runeberg commented 1 year ago

(I changed my mind on this and decided that cleaning up the PR a little bit and just leaving it for @1runeberg to decide is fine)

Great thanks! I'll have a look this weekend. Likely add it to the openxr interactions demo as well in the dev branch

1runeberg commented 1 year ago

Hi @CharlotteGore,

Thanks again for your contribution. For #2 this seems to be just the tracker (no headless). I've had to make some modifications as well, here are the details:

Initial merge in: https://github.com/1runeberg/OpenXRProvider_v2/commit/ad44139634f4f9e52ac91344f0bf68e2c2dd222a Detailed Modifications to PR here: https://github.com/1runeberg/OpenXRProvider_v2/commits/pr/htcx_tracker

This may have affected Linux builds which I noticed you've added support for. Let me know if that's the case and happy to get any fix(es) from you for the linux build as I don't have one handy for this project atm.

Cheers and thanks, Rune

CharlotteGore commented 1 year ago

I'm on Windows so yeah no worries about the linux thing from me, any linux support I added wasn't intentional tbh.

I definitely prefer your approach to handling tracker action bindings btw. Thanks @1runeberg !

1runeberg commented 1 year ago

Will do a headless branch as well, just found the headless code bits you have in the PR as well - I'll provide credit, but I'll rewrite from scratch just so the code path on implementing this is clearer, and not mixed with the tracker which is now merged. just for those who might stumble into this in the future trying to understand the extension.

Thanks @CharlotteGore !

CharlotteGore commented 1 year ago

Honestly fine me me, I don't care about Github Contributor stats tbh, I just wanted the headless openxr session, that's it :D