search

1simjustin / pe

0 stars 0 forks source link

Comma after last item #12

Open 1simjustin opened 2 months ago

1simjustin commented 2 months ago

image.png

In the warning message for duplicate items in the storage file, a trailing comma is produced.

nus-pe-bot commented 2 months ago

Team's Response

This is the intended output message, the duplicated item name is still read as bcd. The trailing command is merely to separate the line from the next line.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I do not dispute that the output message is as intended, but it is regardless a bug as it does not behave as expected, i.e. your intentions do not align with expectations. I find that having a comma in that position is misleading and constitutes a bug in the form of a typo, especially since it would have been trivial to resolve. You may find that the trailing comma is used to separate the line from the next but linguistically that does not make sense.

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** According to the textbook, a functionality bug refers to: `A functionality does not work as specified/expected.` while a feature flaw refers to: `Some functionality missing from a feature delivered in v2.1 in a way that the feature becomes less useful to the intended target user for normal usage. i.e., the feature is not 'complete'.` Based on my interpretation, a feature flaw refers to a bug in the DESIGN of the application while a functionality bug refers to a bug in the IMPLEMENTATION of the application. As an issue which can arguably be played down to a typo, I find that this constitutes a functionality bug moreso than a feature flaw since it is with respect to specifically how the string is output.