search

1simjustin / pe

0 stars 0 forks source link

User shown to have dependency on `Main` in overall class diagram #14

Open 1simjustin opened 2 months ago

1simjustin commented 2 months ago

image.png

Dashed line is used to represent a dependency which would be inaccurate in this case as the user does not depend on Main. User should have been left out in this case.

nus-se-bot commented 2 months ago

Team's Response

This is not a class diagram, it is an architecture diagram, I don't think it has to follow class diagram notations

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This issue should not be rejected. Even if you are representing an architecture diagram as claimed, it does not follow any known convention for architecture diagrams.

Of note, an architecture diagram is used to represent DATA FLOW rather than the way various components interact with one another, which is what the comments tagged along with the arrows seem to suggest. Further, your diagram fails to represent the various levels at play in an application (internal vs external at the minimum).

Agreeably an architecture diagram would not have to follow the conventions of a class diagram. However, it should regardless follow the conventions of an architecture diagram, which your diagram has failed to do so.