1simjustin / pe

0 stars 0 forks source link

Does not make sense to have past expiry dates #3

Open 1simjustin opened 2 months ago

1simjustin commented 2 months ago

image.png

Users are able to set an expiry date to be one that has passed but this does not make sense given that it is meant for a supermarket to track their inventory - no supermarket should be stocking expired items. Understandably there is a feature to detect expired items but being able to set it to expired would be erroneous.

soc-se-bot commented 2 months ago

Team's Response

This is a duplicate of issue of 1069 because both update and new use the same method to parse dates.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Allows expired items to be added to inventory

Screenshot 2024-04-19 at 4.30.07 PM.png

Does not make much logical sense to add an item which is expired into the inventory. The expired date could be due to the user inputing a the wrong date but the app should account for invalid dates.


[original: nus-cs2113-AY2324S2/pe-interim#963] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png As stated in our FAQ, we want to provide our users with more flexibility.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]