1stel / stratostack-portal

StratoSTACK Billing Portal
16 stars 9 forks source link

Laravel 5.2 Shift #2

Closed bowyern closed 7 years ago

bowyern commented 7 years ago

This pull request includes the changes for upgrading to Laravel 5.2. Feel free to commit any additional changes to the laravel-5.2-shift branch.

Before merging, you should:

If you would like more help with your upgrade, check out the new human services from Laravel Shift.

bowyern commented 7 years ago

❌ Laravel 5.2 modified the default Middleware. Since your middleware differs from the Laravel 5.1 default, you will need to compare the following middleware against the 5.2 versions and merge any changes.

bowyern commented 7 years ago

⚠ Laravel 5.2 adds Middleware Groups for convenience. Since this may affect your routes and controllers, I did not automate this upgrade. You should read about Middleware Groups to understand this change.

When you are ready to upgrade to Middleware Groups, you should:

bowyern commented 7 years ago

❌ The Authentication configuration changed significantly in Laravel 5.2. Since your config/auth.php differs from the Laravel 5.1 default, you will need to compare yours against the 5.2 version and merge any changes.

bowyern commented 7 years ago

ℹ Laravel 5.2 changed the value of $redirectTo from /home to / in app/Http/Controllers/Auth/AuthController.php. I did not make this change since you may have customized it for your app. However, you may wish to change this if you are not using Auth or if you want to follow the latest Laravel conventions.

bowyern commented 7 years ago

❌ Laravel 5.2 condenses the default User model dramatically. Since your app/User.php differs from the Laravel 5.1 default, you will need to compare yours against the 5.2 version and merge any changes.

bowyern commented 7 years ago

slice, chunk, and reverse methods now preserve keys on the collection in Laravel 5.2. You should review your usage of these methods.

I found potential uses of these methods in:

bowyern commented 7 years ago

ℹ Laravel 5.2 updated the database session driver. If you are using the database driver, you need to add the user_id (nullable integer), ip_address (nullable string), and user_agent (text) columns to your session database table.

bowyern commented 7 years ago

⚠ I was unable to update phpunit.xml since yours differed from the Laravel default. You need to compare your phpunit.xml with the Laravel 5.2 version and merge any changes.

bowyern commented 7 years ago

❌ Laravel 5.2 updated the public/.htaccess to handle the Authorization header. Since your public/.htaccess file differed from the Laravel default, you need to review the Laravel 5.2 version and merge any changes.

bowyern commented 7 years ago

❌ Laravel 5.2 updated some of the default validation messages. Since your resources/lang/en/validation.php differed from the Laravel default, you need to review the Laravel 5.2 version and merge any changes.

bowyern commented 7 years ago

ℹ Laravel 5.2 added the env configuration option. Laravel strongly recommends you only use env() from configuration files and use config() within your app.

I found potential uses of env() in:

bowyern commented 7 years ago

❌ I could not upgrade the following configuration files since they differed from the 5.1 defaults. You need to compare these configuration files against the default Laravel 5.2 configuration files and merge any changes:

bowyern commented 7 years ago

ℹ Laravel 5.2 removed the pretend mail configuration option. If you were using pretend, use the log driver instead.

bowyern commented 7 years ago

⚠ Laravel 5.2 upgraded some of the Node package dependencies. You should to compare your package.json with the Laravel 5.2 version to update your dependencies.