1stel / stratostack-portal

StratoSTACK Billing Portal
16 stars 9 forks source link

Laravel 5.3 Shift #3

Closed bowyern closed 7 years ago

bowyern commented 7 years ago

This pull request includes the changes for upgrading to Laravel 5.3. Feel free to commit any additional changes to the shift-2399 branch.

Before merging, you should:

If you would like more help with your upgrade, check out the human services from Laravel Shift. And if you want to level-up your Git skills, check out Getting Git.

bowyern commented 7 years ago

❌ Shift could not upgrade the following core files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.3 versions and merge any changes:

bowyern commented 7 years ago

❌ Laravel 5.3 split the Auth/AuthController.php into the Auth/LoginController.php and the Auth/RegisterController.php. Since yours appears to be customized, Shift did not remove it. You should compare your Auth/AuthController.php with the newly added controllers and merge your changes accordingly.

bowyern commented 7 years ago

❌ Laravel 5.3 renamed the Auth/PasswordController.php to Auth/ResetPasswordController.php. Since yours appears to be customized, Shift did not remove it. You should compare your Auth/PasswordController.php against the added Auth/ResetPasswordController.php and merge your changes accordingly.

bowyern commented 7 years ago

⚠ If you are using Authentication, you should upgrade any routes using AuthController and PasswordController to use the new authentication controllers. Laravel recommends using the Auth::routes() which registers the proper routes for the new authentication controllers. This method also registers a POST route for /logout instead of a GET route.

bowyern commented 7 years ago

❌ Shift could not upgrade app/Providers/AuthServiceProvider.php. You will need to compare yours against the 5.3 version and merge the new changes.

bowyern commented 7 years ago

❌ Shift could not upgrade app/Providers/EventServiceProvider.php. You will need to compare yours against the 5.3 version and merge the new changes.

bowyern commented 7 years ago

❌ Shift could not upgrade app/Providers/RouteServiceProvider.php. You will need to compare yours against the 5.3 version and merge the new changes.

bowyern commented 7 years ago

⚠ Laravel 5.3 now includes a top-level routes folder. In addition, it separates routes into API, console, and web files.Shift included a default routes/api.php and routes/console.php as well as migrated your app/Http/routes.php to routes/web.php. You should review your routes to see if they should be separated into one of the new route files.

bowyern commented 7 years ago

⚠ The default behavior of Route::resource() changed in Laravel 5.3. All resource route parameters are now singularized by default and URL prefixes no longer affect the route names.You should review your resource routes and verify this singularized naming will not affect your parameters (or if you were doing this manually, you can remove the parameter). In addition, verify you are no longer appending the URI prefix to the route name.

Found Route::resource() in:

bowyern commented 7 years ago

❌ Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.3 configuration files and merge any changes:

bowyern commented 7 years ago

❌ Implicit controller routes using Route::controller were deprecated in Laravel 5.2 and removed in Laravel 5.3. Instead you should register your routes explicitly. You may be able to automate the conversion with an artisan command.

Found Route::controller() in:

bowyern commented 7 years ago

❌ Shift detected the Forms and HTML package by the Laravel Collective. The recommended version is 5.3.* for Laravel 5.3. You should review your laravelcollective/html dependency to ensure it is compatible. Review the Installation Docs for more details.

bowyern commented 7 years ago

❌ Laravel 5.3 has a development dependency for symfony/css-selector of 3.1.*. You have a modified dependency for symfony/css-selector in your composer.json. Ensure it meets the new version requirement of 3.1.*.

bowyern commented 7 years ago

❌ Laravel 5.3 has a development dependency for symfony/dom-crawler of 3.1.*. You have a modified dependency for symfony/dom-crawler in your composer.json. Ensure it meets the new version requirement of 3.1.*.

bowyern commented 7 years ago

❌ Laravel 5.3 where performs a "loose" comparison. In addition, the strict parameter was removed. If you need to perform a "strict" comparison, you can use whereStrict instead.

You should review the following usages of where to ensure you do not require "strict" compaison:

bowyern commented 7 years ago

❌ The Query Builder returns collections, instead of plain arrays, in Laravel 5.3. You will need to upgrade your code to use collections or chain the all() method onto your query to return a plain array.

You should review the following usages of Query Builder:

bowyern commented 7 years ago

ℹ If you are using Queues, you no longer need to specify the --daemon option when calling the queue:work. This is assumed in Laravel 5.3. Use the --once option to process a single job.

bowyern commented 7 years ago

ℹ If you are using the database driver for your Queue, you will need to update your jobs and failed_jobs table. Review the Queue section of the Laravel 5.3 Upgrade Guide for more details and feel free to use the migrations from Laravel Shift.

bowyern commented 7 years ago

ℹ Laravel 5.3 updated several of the default assets as well as adding support for Vue.js. If you are using Laravel to compile assets you may want to review the latest versions of resources/assets/js/app.js and resources/assets/sass/app.scss and update your project accordingly.

bowyern commented 7 years ago

⚠ Laravel 5.3 added configuration for your application name in config/app.php. Be sure to set this value as it is used in notifications, like the password reset email.

bowyern commented 7 years ago

ℹ If you have manually upgraded your app from previous versions of Laravel, you should run the Laravel Linter to ensure your app is fully upgraded to the latest version of Laravel.