search

1szheng / pe

0 stars 0 forks source link

Program does not exit gracefully on forced exit #15

Open 1szheng opened 2 years ago

1szheng commented 2 years ago

Application throws an exception on execution of the Ctrl + C key combination. Some users might choose to issue this command instead of issuing the normal exit command.

image.png

nus-pe-bot commented 2 years ago

Team's Response

The following is considered extreme behaviour. We were also not taught about signal handlers.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is not an extreme user behavior as this is a legitimate way of ending the process of an application.

Not being taught about signal handlers is not an excuse to not handle such exceptions. This exception is not explicitly due to the signal handler but the lack of catching it.

As seen in the screenshot, it is as simple as mousing over the method to find out what exception it may throw. Therefore, this is due to the developer's lack of due diligence.

image.png

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This is not a cosmetic issue, I am not sure why it is moved to Very Low.

Does the developer feel that it is either a typo, spacing, layout, color or font issue? This was not justified.

image.png