1szheng / pe

0 stars 0 forks source link

Add Command implementation diagram unreadable #24

Open 1szheng opened 2 years ago

1szheng commented 2 years ago

The diagram for add command's implementation cannot be easily read by the reader as it is too zoomed out.

Suggest splitting the diagram into parts, add references or reduce the width somehow.

image.png

soc-pe-bot commented 2 years ago

Team's Response

This issue has been previously raised by our TA and we have acted upon his suggestion to improve the resolution of our diagrams. The diagram can be read upon zooming in; it would be an issue if the text, boxes or arrows were blurry.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: Since the issue has been previously raised before, it should have been dealt with in the appropriate manner. Improving the resolution of the diagram is not the answer to having text that are too small to be read. One could argue that if that is the case, why not just put your entire document in font size 6 and have the readers zoom in? Since the document can be read upon zooming in.

This issue can be said to also affect the reader's usability of the document as the diagram is nigh unreadable and there were no indication on this section of the document to zoom in as seen below. However, since this is ultimately a spacing and layout issue, it should be accepted as a cosmetic issue to be fixed.

image.png

image.png