1szheng / pe

0 stars 0 forks source link

Non-standardized color scheme between different diagrams #27

Open 1szheng opened 2 years ago

1szheng commented 2 years ago

The usage of colors in the diagrams are different between certain diagrams which may indicate to the reader that they are not referring to the same object.

The colors for each object should be standardized across diagrams.

image.png

image.png

nus-pe-bot commented 2 years ago

Team's Response

Think this is very minor. Even if we were to standardise the colour scheme, a user would have to read the diagram closely to know that we are referring to a particular object.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While this is a minor issue, the developer has agreed that this is an issue. In their reply, they have stated that a user would have to read the diagram closely, to which a developer reading this guide is supposed to be doing.

The purpose of standardizing the color scheme is to assist the developers when they are looking at diagrams.

In accordance with the severity level of very low, I feel that due to the cosmetic nature of this issue, it should be accepted.

image.png