search

1szheng / pe

0 stars 0 forks source link

Unintuitive return feature #6

Open 1szheng opened 2 years ago

1szheng commented 2 years ago

The return command is unintuitive and does not allow user to control which borrowed entry is returned. For the picture below, if BETA was the borrower who returned the item, the user is unable to let BETA's borrow be marked as returned without affecting the previous borrow.

This means that John Smith's borrow would need to be returned if BETA returns his borrow.

image.png

soc-pe-bot commented 2 years ago

Team's Response

This bug was created as a result of the "Return" command being designed with the thought that there would only be 1 quantity of each item. For items with only 1 item quantity, this bug would not be an issue as there would only be 1 overdue/outstanding borrowing at any point in time, and the relevant overdue/outstanding borrow record would be marked as returned.

However, with that being said, it is true that this bug would be a problem whenever an item consists of quantity greater than 1 and partial quantities of an item are borrowed at the same time. The command would return the borrow record that was entered into the system first. However, we do not think that this warrants a severity high as this bug would not affect ALL items in the inventory (only items with quantity greater than 1). Plus, this error would only pop up when there are borrow records with overlapping durations on the same item. Without overlapping borrow records, this bug would not show up. It would also not render the entire application entirely unusable (In the worst case, the user can still list individual items and borrow them individually).

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: As explained by the developer, this bug only occurs with items that have quantity greater than 1, and when there are borrow records with overlapping duration on the same item.

From the intended target audience of this application, we know that this is an inventory manager for CCA clubs. It follows that since the club would require an inventory manager, it would have many items with quantity greater than 1. If said CCA club is the type to loan out equipment, such as musical instruments, sports equipment and the likes, there is a high probability that there will be multiple borrow records of overlapping duration each time the CCA has a session.

This would render the application almost unusable for the purpose of managing loaned inventory in its entirety as it cannot be controlled.

If the developers would like to say that the app is still usable to list individual items, thus should not be a severity of High, then I would like to suggest users of the application to use Notepad or Microsoft Excel instead.