1szheng / pe

0 stars 0 forks source link

Items cannot be borrowed on the date of returning #8

Open 1szheng opened 2 years ago

1szheng commented 2 years ago

Items cannot be borrowed on the date that they have been returned to the inventory. This characteristic is unrealistic and does not suffice in the actual real world requirements of an inventory manager. Items can be borrowed, returned and loaned out again on the same date.

image.png

image.png

nus-se-bot commented 2 years ago

Team's Response

We have discussed this as a team and we have come to a consensus that in reality, when it comes to loaning items for CCA management, stakeholders do not borrow items that are returned on the same day. For proper management, borrowing is usually done the day after where we can better guarantee that the item would be in storage and available for loan.

In our demo video we have also explained that the return command will edit the date of the borrow record to the current date; this is based on the assumption that the item is unavailable for borrowing on the same day.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

return today but still in the current borrowing list.

image.png

image.png

If I return the item it will still show up in listcb current borrowing list. But they are not supposed to show up in the current borrowing list because otherwise, the user will think that they still haven't returned it yet.


[original: nus-cs2113-AY2122S2/pe-interim#351] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The developers did not prove that the issue was not in scope.

Developers mentioned that they have come to a consensus that in reality loaned items for CCA are not borrowed out on the day of return. If this was the reason and they felt that it was a suboptimal design for the NotInScope, I have to disagree.

Their UG does not that this is an intended interaction between borrowing and returning, and users are able to attempt to use this feature. Additionally, it is false that all CCAs do not borrow out items that are returned on the day itself.

image.png

image.png

image.png


:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]