search

1technophile / OpenMQTTGateway

MQTT gateway for ESP8266 or ESP32 with bidirectional 433mhz/315mhz/868mhz, Infrared communications, BLE, Bluetooth, beacons detection, mi flora, mi jia, LYWSD02, LYWSD03MMC, Mi Scale, TPMS, BBQ thermometer compatibility & LoRa.
https://docs.openmqttgateway.com
GNU General Public License v3.0
3.6k stars 792 forks source link

Values swapped for ds1820 sensor #1072

Closed amatamalas closed 2 years ago

amatamalas commented 3 years ago

Hi all,

I have spotted a bug/typo for the DS1820 sensor in the development branch. The values for tempf and tempc are currently swapped. I'm happy to submit a PR as it's a trivial change in code and be able to provide my small grain of sand to this amazing project.

I have been looking into the code history and seems that it was introduced on #703 and carried on during some refactoring of the code.

Kind regards, Antoni

1technophile commented 3 years ago

Hi,

Feel free to submit a PR!

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.