search

1technophile / OpenMQTTGateway

MQTT gateway for ESP8266 or ESP32 with bidirectional 433mhz/315mhz/868mhz, Infrared communications, BLE, Bluetooth, beacons detection, mi flora, mi jia, LYWSD02, LYWSD03MMC, Mi Scale, TPMS, BBQ thermometer compatibility & LoRa.
https://docs.openmqttgateway.com
GNU General Public License v3.0
3.57k stars 786 forks source link

WebUI is missing quotes on placeholder attributes #1873

Closed g-regor closed 1 month ago

g-regor commented 8 months ago

For example when MQTT_SERVER is set to "", HTML is served as <input id='mh' placeholder= value='mqtt-broker.local'>, which the browser parses as <input id="mh" placeholder="value='mqtt-broker.local'" name="mh"> and is then shown as image

The same problem also occurs for MQTT_PORT, MQTT_USER and Gateway_Name. Space in the value is also problematic as it makes it show up only partialy. i.e. for #define Gateway_Name "OpenMQTTGateway One" it only shows "OpenMQTTGateway" as the placeholder.

Steps to reproduce the behavior:

  1. Build the firmware (v1.7.0) with WebUI enabled and with MQTT_SERVER, MQTT_PORT, MQTT_USER and Gateway_Name set as empty strings.
  2. Configure the gateway
  3. Check the MQTT configuration on the WebUI
github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] commented 5 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.

github-actions[bot] commented 2 months ago

This issue is stale because it has been open for 90 days with no activity.

github-actions[bot] commented 1 month ago

This issue was closed because it has been inactive for 14 days since being marked as stale.