1thenikita / Visual-Studio

A Discord Rich Presence extension for both Visual Studio 2017 and 2019.
https://marketplace.visualstudio.com/items?itemName=VisualDevelopment.drpcvs2019
GNU Affero General Public License v3.0
92 stars 32 forks source link

Error message "bad exception" #52

Closed yvvki closed 3 years ago

yvvki commented 3 years ago

Bug description:

Visual Studio 2019 Preview will show an error message saying "bad exception" when trying to close the app when there's a unsaved file while using this extension.

Visual Studio won't quit afterwards without crashing it via task manager.

Reproduction steps:

Steps to reproduce the behavior:

  1. Edit any file on visual studio
  2. Close the app without saving
  3. See error message

Expected behavior:

A prompt to quit, shows unsaved file, then quit successfully.

Screenshots:

https://imgur.com/a/kvM4PwR

Desktop:

Additional context

Log: https://pastebin.com/7tAqpU3B

Fun fact, if you editing another file after the error show and going back to the unsaved file, it will freeze VS and crash it.

Thanks!

1thenikita commented 3 years ago

Good afternoon! Try to update your extension to a newer version, maybe the problem will disappear.

TheLeftExit commented 3 years ago

Just encountered the same issue on 5.5.3.

VS would show "Fatal error 0x8000FFFF" when attempting to save a file and "Unable to access disposed object Discord IPC" when trying to change any settings through the extension's menu.

In the end it crashed, as @YvvkiRika reported, as I was opening a new file after encountering the error message.

It seems like the extension disposes of the DRP server once you attempt to close VS, resulting in crashes if the attempt was interrupted by stuff like "Save unsaved files" dialog.

Edit: requested to pull a fix in #77

1thenikita commented 3 years ago

An update is on its way! You can wait and get the update from the marketplace or download it manually here.