search

1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.
MIT License
634 stars 118 forks source link

Add possibility to add custom factories tagged services. #127

Closed chosroes closed 7 years ago

chosroes commented 7 years ago

Should do the job for #115

bytehead commented 7 years ago

I'm not sure, if this changes anything?
Some code just moved from getFactories() method into load() method...

bytehead commented 7 years ago

Nevermind. I think i got it 😄 .

chosroes commented 7 years ago

@bytehead I changed my commit earlier, could this have made the travis build fail ?

bytehead commented 7 years ago

Nope, you have to fix it here: https://github.com/chosroes/OneupFlysystemBundle/blob/master/DependencyInjection/OneupFlysystemExtension.php#L52 (pass the $container into $this->getFactories()).

chosroes commented 7 years ago

Yes, I missed it...

bytehead commented 7 years ago

Will you fix it? Otherwise you should click Allow edits from maintainers. :)

chosroes commented 7 years ago

@bytehead I fixed it

bytehead commented 7 years ago

Can't see the change. Did you push?

bytehead commented 7 years ago

Thank you!