1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.
MIT License
634 stars 118 forks source link

Invalid bucket configuration example in Google Cloud Storage adapter documentation #170

Closed vladimirdotk closed 6 years ago

vladimirdotk commented 6 years ago

If you use this example:

acme.google_storage_bucket:
    class: Google\Cloud\Storage\Bucket
    factory: 'acme.google_storage_client:bucket'
    arguments:
        name: 'your-bucket-name'

than name string will be added to url, so it will look like this: https://storage.googleapis.com/storage/v1/b/name,your-bucket-name/o/file.txt

That's why bucket part of config should look like this:

acme.google_storage_bucket:
    class: Google\Cloud\Storage\Bucket
    factory: 'acme.google_storage_client:bucket'
    arguments:
        - 'your-bucket-name'
bytehead commented 6 years ago

Fixed in #171.