1up-lab / OneupFlysystemBundle

A Flysystem integration for your Symfony projects.
MIT License
630 stars 118 forks source link

Features request: download helper and zip generation helper #186

Closed fabienlem closed 5 years ago

fabienlem commented 5 years ago

Hello!

I would like to suggest features addition on this bundle.

Download helper

The first one is to provide an helper that allow file download. It's something not really straight forward and I had trouble finding out how to do it.

The Vich Uploader bundle provide a such feature see: createDownloadResponse().

Zip generation helper

The second one is to add a shortcut that allow zip generation. I think it would be nice to provide a way to generate one-shot zip archives, ie: without any yaml configuration.

Possible use-cases:

I found this code sample that could be reworked on this purpose.

Thank you for reading and for your feedback!

Fabien

bytehead commented 5 years ago

Hello

Thanks for your contribution!

It's not this bundle's responsibility to provide a download helper nor a zip generation helper. This bundle just glues the flysystem php library into the symfony (bundle) ecosystem.

But as stated in the mentioned code example, it's pretty easy to implement this kind of logic yourself.

I'll close this because it's out of this bundle's scope.