Add flysystem adapter for AsyncAws S3

[aziz-harazi]

Hello, does the package will use async-aws/flysystem-s3 dependency instead of league/flysystem-aws-s3-v2soon ?

Thank you

[bytehead]

It actually suggests to use league/flysystem-aws-s3-v3 if you want to use v3: https://github.com/1up-lab/OneupFlysystemBundle/blob/master/composer.json#L61

[aziz-harazi]

Thank you for your response. with oneup/flysystem-bundle, we have dependency with flysystem-aws-s3-v2(3) which have dependency aws/aws-sdk-php which is loading all services.

async-aws/flysystem-s3 has dependency with async-aws/core and async-aws/s3 we will not have to get all aws services.

Thank you and have a good day

[aziz-harazi]

Are you going to include async-aws/flysystem-s3, in a future version ?

[bytehead]

Yes that could be an enhancement!

[bytehead]

I just don't have any time plan as my free time at the moment is quite limited.

[bytehead]

You could try to add your custom filesystem with https://github.com/1up-lab/OneupFlysystemBundle/blob/master/Resources/doc/adapter_custom.md and https://async-aws.com/integration/flysystem.html

[aziz-harazi]

Thank you very much. I'm going to try it.

[bytehead]

Did you end up successfully trying it via custom adapter?

[aziz-harazi]

Hello, i'm coing to fix or this week. I will sens a pull request to you

Le lun. 25 mai 2020 à 15:29, David Greminger notifications@github.com a écrit :

Did you end up successfully trying it via custom adapter?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/1up-lab/OneupFlysystemBundle/issues/208#issuecomment-633573126, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOYTSY6ASEBHZEDHSLMDTKTRTJXC5ANCNFSM4ND2THDA .

[Nyholm]

I added a PR for this in #209

[bytehead]

Thank you Tobias! I'll check the PR asap :)

[bytehead]

Closed in favor of #209